Add wrongly removed statement back to codebase#612
Merged
Conversation
This was removed in the process of making the linter happy. But it is required since it changes `num_channels`. @christiansandberg this fixes the problem found by you
christiansandberg
approved these changes
Jun 3, 2019
Collaborator
christiansandberg
left a comment
christiansandberg
left a comment
There was a problem hiding this comment.
You could also remove the comment since the return value is checked and an error raised if it is not 0.
Codecov Report
@@ Coverage Diff @@
## develop #612 +/- ##
==========================================
+ Coverage 63.65% 63.85% +0.2%
==========================================
Files 63 63
Lines 5544 5545 +1
==========================================
+ Hits 3529 3541 +12
+ Misses 2015 2004 -11 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #612 +/- ##
==========================================
+ Coverage 63.65% 63.85% +0.2%
==========================================
Files 63 63
Lines 5544 5545 +1
==========================================
+ Hits 3529 3541 +12
+ Misses 2015 2004 -11 |
karlding
added a commit
to karlding/python-can
that referenced
this pull request
Jun 3, 2019
…multiple_cyclic_messages * upstream/develop: Add wrongly removed statement back to codebase (hardbyte#612)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed in the process of making the linter happy. But it is required since it changes
num_channels.@christiansandberg this fixes the problem found by you